Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84128164
@zsxwing the approach looks reasonable. I'm wondering if there's a more
readable way to do the same thing. In particular, currently this uses
call-by-name (`tryToPut`, `dropFromMemory`...) and multiple parameters (your
new `MemoryStore#putBytes`), which we actually discourage in the Databricks
style guide: https://github.com/databricks/scala-style-guide. How much of a
change will this patch be instead if we rewrite this patch according to the
style guide?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
