dongjoon-hyun commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r439852420
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -420,6 +420,21 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val STORAGE_SHUFFLE_DECOMMISSION_ENABLED =
+ ConfigBuilder("spark.storage.decommission.shuffle_blocks")
+ .doc("Whether to transfer shuffle blocks during block manager
decommissioning. Requires " +
+ "an indexed shuffle resolver (like sort based shuffe)")
Review comment:
It would be great if we have a defensive code somewhere in this PR for
this requirement. For example, `assert()` in the code?
> Requires an indexed shuffle resolver (like sort based shuffe)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
