HeartSaVioR commented on a change in pull request #28607:
URL: https://github.com/apache/spark/pull/28607#discussion_r439861427
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
##########
@@ -77,6 +77,8 @@ trait StateStoreWriter extends StatefulOperator { self:
SparkPlan =>
override lazy val metrics = Map(
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
+ "numLateInputs" -> SQLMetrics.createMetric(sparkContext,
Review comment:
Thanks for the suggestion. Yeah I guess I tried to explain the behavior
but the name seems to be still confusing to others. I agree the suggested name
is clearer.
Btw, would we be better to have accurate number of late inputs? (Just asking
because #24936 covers this, and can be applied orthogonally like num of late
inputs vs num of dropped inputs.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
