HeartSaVioR commented on a change in pull request #28830:
URL: https://github.com/apache/spark/pull/28830#discussion_r439904302
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest
assert(df.schema === new StructType().add(StructField("d",
DecimalType(38, 0))))
}
}
+
+ test("SPARK-31990: preserves the input order of colNames in dropDuplicates")
{
+ val df = Seq((1, 2, 3, 4, 5), (1, 2, 3, 4, 5)).toDF("c", "e", "d", "a",
"b")
+ val inputColNames = Seq("c", "b", "c", "d", "b", "c", "b")
Review comment:
Technically, as you're implementing the same as `distinct` does, it
doesn't fix the issue for restoring from old checkpoint. Both Spark 3.x and
your patch will fail. That's what I commented in JIRA - "do the right fix" vs
"leave it as it is".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
