Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5093#discussion_r26882829
--- Diff: dev/tests/pr_new_dependencies.sh ---
@@ -0,0 +1,77 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#
+# This script follows the base format for testing pull requests against
+# another branch and returning results to be published. More details can be
+# found at dev/run-tests-jenkins.
+#
+# Arg1: The Github Pull Request Actual Commit
+#+ known as `ghprbActualCommit` in `run-tests-jenkins`
+# Arg2: The SHA1 hash
+#+ known as `sha1` in `run-tests-jenkins`
+#
+
+ghprbActualCommit="$1"
+sha1="$2"
+
+CURR_CP_FILE="my-classpath.txt"
+MASTER_CP_FILE="master-classpath.txt"
+
+./build/mvn clean compile dependency:build-classpath | \
+ sed -n -e '/Building Spark Project Assembly/,$p' | \
+ grep --context=1 -m 2 "Dependencies classpath:" | \
+ head -n 3 | \
+ tail -n 1 | \
+ tr ":" "\n" | \
+ rev | \
+ cut -d "/" -f 1 | \
+ rev | \
+ sort > ${CURR_CP_FILE}
+
+# Checkout the master branch to compare against
+git checkout apache/master
+
+./build/mvn clean compile dependency:build-classpath | \
+ sed -n -e '/Building Spark Project Assembly/,$p' | \
+ grep --context=1 -m 2 "Dependencies classpath:" | \
+ head -n 3 | \
+ tail -n 1 | \
+ tr ":" "\n" | \
+ rev | \
+ cut -d "/" -f 1 | \
+ rev | \
+ sort > ${MASTER_CP_FILE}
+
+DIFF_RESULTS="`diff my-classpath.txt master-classpath.txt`"
+
+if [ -z "${DIFF_RESULTS}" ]; then
+ echo " * This patch adds no new dependencies."
+else
+ # Pretty print the new dependencies
+ new_deps=$(echo ${DIFF_RESULTS} | grep "<" | cut -d" " -f2 | awk '{print
" * "$1}')
+ echo " * This patch **adds the following new
dependencies:**\n${new_deps}"
--- End diff --
It would actually be good to show additions and removals of dependencies
(in some cases a library will get a new version, which ends up here as an
addition and removal). I updated the JIRA title to reflect that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
