Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5009#issuecomment-84176551
I'm not a fan of "ratio" since none of the options we want are represented
as ratios. My votes would be for one of the following, depending on how
pluggable we plan to make this eventually:
* "featuresPerNode" or "featureSubset": Both of these are shorter and
clearer to me than other options.
* "featureSubsetStrategy": If we eventually want users to be able to pass
in fancy functions beyond log and sqrt, then "strategy" could be meaningful.
For enum-like types, I'll mimic your example from the dev list, but per our
discussions, I'll only expose Strings for now and will keep the enum-like types
private. I'd like to expose the enum-like types eventually and even make them
pluggable, but we'll postpone that discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
