HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644120378
My bad I missed the existing test, as I target on older Spark version originally. The existing UT works with this patch, because we don't create local variables for dealing with literals (it just seems to leverage global array.) Looks like we should deal with splitting code block in any way. Let me change the PR to WIP for now and try to come up with another solution. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
