guykhazma commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-644146555
@maropu which test do you suggest to add? This is private function which is not tested anywhere also not all file formats are able to save the metadata (for example csv) so seems to me that adding a test to [SchemaPruningSuite](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SchemaPruningSuite.scala) is not the right thing. I can add a test similar to the above code snippet, if that seems ok to you where would you suggest to put it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
