GuoPhilipse commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r440313281



##########
File path: sql/hive/src/test/resources/golden/timestamp cast 
#3-0-732ed232ac592c5e7f7c913a88874fd2
##########
@@ -1 +0,0 @@
-1.2

Review comment:
       if we remove it, there will be lack of testing for casting from double 
to timestamp for createQueryTest, we may need to add the legacy to let the test 
case pass.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to