yaooqinn commented on a change in pull request #28835:
URL: https://github.com/apache/spark/pull/28835#discussion_r440743061
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
##########
@@ -94,6 +95,12 @@ private[hive] class SparkSQLCLIService(hiveServer:
HiveServer2, sqlContext: SQLC
initCompositeService(hiveConf)
}
+ /**
+ * the super class [[CLIService#start]] starts a useless dummy metastore
client, skip it and call
+ * the ancestor [[CompositeService#start]] directly.
+ */
+ override def start(): Unit = startCompositeService()
Review comment:
CLIService will create a metastore connection during start, which is
useless for our dummy execution hive conf and will cause class cast issue
though different classloader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
