fqaiser94 commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r441184204



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -539,3 +541,82 @@ case class StringToMap(text: Expression, pairDelim: 
Expression, keyValueDelim: E
 
   override def prettyName: String = "str_to_map"
 }
+
+/**
+ * Adds/replaces field in struct by name.

Review comment:
       Sorry I forgot to do this earlier but I've posted a comment now 
describing the changes I've made and their impact 
[here](https://github.com/apache/spark/pull/27066#issuecomment-645047815). 
   
   Yes, you are correct. The `WithFields` expression will now only add/replace 
top-level fields in a struct. It's just a programming exercise to use 
`WithFields` in conjunction with`GetStructField` to add/replace _nested_ fields 
in a struct. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to