jiangxb1987 commented on a change in pull request #28839:
URL: https://github.com/apache/spark/pull/28839#discussion_r441298122



##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala
##########
@@ -275,7 +275,8 @@ class BarrierTaskContextSuite extends SparkFunSuite with 
LocalSparkContext with
   }
 
   test("SPARK-31485: barrier stage should fail if only partial tasks are 
launched") {
-    initLocalClusterSparkContext(2)
+    val conf = new SparkConf().set(LOCALITY_WAIT_PROCESS.key, "10s")

Review comment:
       Now that we have waited until all the executors has been launched before 
we submit any jobs, thus upon the first time we try to offer the resources to 
the pending tasks, we should expect all the executors are available and the 
locality preference should be satisfied, this shouldn't change following 
different locality wait time. cc @Ngone51 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to