cloud-fan commented on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-645209161
thanks @fqaiser94 , I like your new changes!
> Internally reuse CreateNamedStruct so that existing optimizations (like
predicate pushdown and schema pruning) can continue to work
Can you explain more about this? My last concern is we convert `WithField`
to `CreateNamedStruct` in a kind of random place in the optimizer. I'm thinking
about something like
```
case class WithField(...) {
private lazy val createNamedStruct = ...
override def eval(input) = createNamedStruct.eval(input)
override def doCodegen(ctx) = createNamedStruct.doCodegen(ctx)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
