maropu commented on a change in pull request #27246:
URL: https://github.com/apache/spark/pull/27246#discussion_r441900348



##########
File path: 
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
##########
@@ -37,6 +37,10 @@
  */
 public final class UnsafeSorterSpillReader extends UnsafeSorterIterator 
implements Closeable {
   public static final int MAX_BUFFER_SIZE_BYTES = 16777216; // 16 mb
+  public static final int DEFAULT_BUFFER_SIZE_RATIO = 1024;

Review comment:
       Could you inline this default value in the config side 
(`createWithDefault(1024)`)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to