kiszk commented on a change in pull request #28831:
URL: https://github.com/apache/spark/pull/28831#discussion_r442030030
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -123,26 +123,41 @@ case class ConcatWs(children: Seq[Expression])
val idxVararg = ctx.freshName("idxInVararg")
val evals = children.map(_.genCode(ctx))
+ val supportSplitExpressions =
ctx.supportSplitExpressionsWithCurrentInputs
+
+ // Here we apply different approaches according to the availability of
splitting expressions.
Review comment:
It would be good to use one approach to reduce the complexity. Could you
please see @cloud-fan 's comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
