MaxGekk commented on a change in pull request #27617:
URL: https://github.com/apache/spark/pull/27617#discussion_r442417064
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -810,36 +793,36 @@ object DateTimeUtils {
}
/**
- * Convert the timestamp `ts` from one timezone to another.
+ * Convert the timestamp `micros` from one timezone to another.
*
* TODO: Because of DST, the conversion between UTC and human time is not
exactly one-to-one
* mapping, the conversion here may return wrong result, we should make the
timestamp
* timezone-aware.
*/
- def convertTz(ts: SQLTimestamp, fromZone: ZoneId, toZone: ZoneId):
SQLTimestamp = {
- val rebasedDateTime =
microsToInstant(ts).atZone(toZone).toLocalDateTime.atZone(fromZone)
+ def convertTz(micros: Long, fromZone: ZoneId, toZone: ZoneId): Long = {
+ val rebasedDateTime =
microsToInstant(micros).atZone(toZone).toLocalDateTime.atZone(fromZone)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
