holdenk commented on a change in pull request #28864:
URL: https://github.com/apache/spark/pull/28864#discussion_r442434806



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -226,9 +226,9 @@ private[spark] class BlockManager(
   private val maxFailuresBeforeLocationRefresh =
     conf.get(config.BLOCK_FAILURES_BEFORE_LOCATION_REFRESH)
 
-  private val slaveEndpoint = rpcEnv.setupEndpoint(
+  private val replicaEndpoint = rpcEnv.setupEndpoint(

Review comment:
       We have `spark.storage.replication.*` which controls how blocks are 
replicated and similar things like `replicateBlock`, but I think replica it's 
self is good. We could also go with "shard" here if we wanted?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to