HeartSaVioR commented on a change in pull request #28831:
URL: https://github.com/apache/spark/pull/28831#discussion_r442563872
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -182,7 +208,9 @@ case class ConcatWs(children: Seq[Expression])
ev.copy(
code"""
- $codes
+ boolean[] $isNullArgs = new boolean[${children.length - 1}];
+ Object[] $valueArgs = new Object[${children.length - 1}];
+ $argBuilds
Review comment:
If I understand correctly, evals.head is a delimiter (so that doesn't
need to be coupled with varargXXX), and it's used in `UTF8String.concatWs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
