Ngone51 commented on a change in pull request #28848:
URL: https://github.com/apache/spark/pull/28848#discussion_r442599457
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1939,24 +1941,23 @@ private[spark] class DAGScheduler(
hostToUnregisterOutputs: Option[String],
maybeEpoch: Option[Long] = None): Unit = {
val currentEpoch = maybeEpoch.getOrElse(mapOutputTracker.getEpoch)
+ logDebug(s"Removing executor $execId, fileLost: $fileLost, currentEpoch:
$currentEpoch")
Review comment:
> See explanation in my response to your comment about the previous
logDebug.
But more importantly, this logDebug tells you that the method is invoked.
Then depending on whether there is additional log output, you know if one or
both of the if clauses are executed as well. (Knowing the value of fileLost may
rule out one of the clauses.)
What if the executor does not meet the if condition? In that case, the
executor is not going to be removed. @wypoon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
