maropu commented on a change in pull request #28840:
URL: https://github.com/apache/spark/pull/28840#discussion_r442654436
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -155,4 +155,37 @@ private[sql] trait LookupCatalog extends Logging {
None
}
}
+
+ /**
+ * Extract catalog and function identifier from a multi-part name with the
current catalog if
+ * needed.
+ *
+ * Note that: function is only supported in v1 catalog.
+ */
+ object CatalogAndFunctionIdentifier {
Review comment:
Yea, moving `parseSessionCatalogFunctionIdentifier` into the catalyst
package looks okay, but I meant you need to refactor
`parseSessionCatalogFunctionIdentifier` as a extractor? Actually, I think you
don't need to update the existing code, e.g.,
https://github.com/apache/spark/pull/28840/files#diff-2e07be4d73605cb1941153441a0c0c14R568-R569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
