maropu commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r442659518



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -835,6 +835,15 @@ object SQLConf {
       .longConf
       .createWithDefault(250 * 1024 * 1024)
 
+  val HIVE_FILESOURCE_PARTITION_FILE_CACHE_TTL =
+    buildConf("spark.sql.hive.filesourcePartitionFileCacheTTL")

Review comment:
       Ah, I see. But, I personally think its better to remove `hive` in that 
name, too, because of the same reason.
   
   >  it's going to be a backwards-incompatible change.
   
   Yea, since we must keep the compatibility, we need to move the current 
config  into `removedSQLConfigs` then add a new config name for that.
   
   cc: @dongjoon-hyun @HyukjinKwon 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to