maropu commented on a change in pull request #28869:
URL: https://github.com/apache/spark/pull/28869#discussion_r442764355
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
##########
@@ -49,7 +49,7 @@ case class SortAggregateExec(
override def producedAttributes: AttributeSet =
AttributeSet(aggregateAttributes) ++
AttributeSet(resultExpressions.diff(groupingExpressions).map(_.toAttribute)) ++
- AttributeSet(aggregateBufferAttributes)
+ AttributeSet(aggregateBufferAttributes) ++ super.producedAttributes
Review comment:
(Tihs is not related to this PR though) `producedAttributes` looks the
same between the three aggregate implementations, so could we move
`producedAttributes` into `BaseAggregateExec`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
