sap1ens commented on pull request #28852: URL: https://github.com/apache/spark/pull/28852#issuecomment-646779246
@maropu > > Do you think I should create a new suite for FileStatusCache? Or try to extend HiveSchemaInferenceSuite? > > How about adding CatalogFileIndexSuite in the hive package? It looks like `CatalogFileIndex` does rely on `InMemoryFileIndex` as well, so the scope of testing is probably more than this change adds... I think that testing `FileStatusCache` exclusively is probably the most straightforward thing to do, but I'm happy to invest more time in testing `CatalogFileIndex` too. If we go ahead with `CatalogFileIndexSuite`, doesn't it make more sense to put it in the core package, where `CatalogFileIndex` is located? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
