dongjoon-hyun commented on a change in pull request #28848:
URL: https://github.com/apache/spark/pull/28848#discussion_r443083551



##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -540,6 +540,42 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
     assert(mapStatus2(2).location.host === "hostB")
   }
 
+  test("[SPARK-32003] All shuffle files for executor should be cleaned up on 
fetch failure") {

Review comment:
       Thank you for adding this UT. BTW, since the recommendation from 
https://spark.apache.org/contributing.html is `SPARK-32003: `, it would be 
great if this follows the guideline.

##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -540,6 +540,42 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
     assert(mapStatus2(2).location.host === "hostB")
   }
 
+  test("[SPARK-32003] All shuffle files for executor should be cleaned up on 
fetch failure") {

Review comment:
       Thank you for adding this UT. BTW, since the recommendation from 
https://spark.apache.org/contributing.html is `SPARK-32003: ...`, it would be 
great if this follows the guideline.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to