maropu commented on a change in pull request #28863: URL: https://github.com/apache/spark/pull/28863#discussion_r443105992
########## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala ########## @@ -32,35 +32,29 @@ import org.apache.spark.tags.DockerTest /** * This patch was tested using the Oracle docker. Created this integration suite for the same. - * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there was - * no jdbc jar available in the maven repository, the jar was downloaded from oracle site - * manually and installed in the local; thus tested. So, for SparkQA test case run, the - * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0) - * while Spark QA test run. * * The following would be the steps to test this * 1. Build Oracle database in Docker, please refer below link about how to. * https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md * 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME * Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME * 3. Start docker - sudo service docker start - * 4. Download oracle 11g driver jar and put it in maven local repo: - * (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar) - * 5. The timeout and interval parameter to be increased from 60,1 to a high value for oracle test - * in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully). - * 6. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite" + * 4. The timeout and interval parameter to be increased to a high value for oracle test in + * DockerJDBCIntegrationSuite.scala (Locally tested with timeout(20.minutes), interval(1.second) + * and executed successfully). + * 5. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite" * - * All tests in this suite are ignored because of the dependency with the oracle jar from maven - * repository. + * It has been validated with 18.4.0 Express Edition. Review comment: This info looks useful, so how about moving it into the comment side like this? ``` * ... * 5. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite" * * An actual sequence of commands to run the test is as follows * * $ git clone https://github.com/oracle/docker-images.git * // Head SHA: 3e352a22618070595f823977a0fd1a3a8071a83c * $ cd docker-images/OracleDatabase/SingleInstance/dockerfiles * $ ./buildDockerImage.sh -v 18.4.0 -x * $ export ORACLE_DOCKER_IMAGE_NAME=oracle/database:18.4.0-xe * $ cd $SPARK_HOME * $ ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite" * * It has been validated with 18.4.0 Express Edition. */ ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
