abellina commented on a change in pull request #28876:
URL: https://github.com/apache/spark/pull/28876#discussion_r443183186
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
##########
@@ -148,7 +149,15 @@ object AggUtils {
case ne: NamedExpression => ne
case other => Alias(other, other.toString)()
}
- val distinctAttributes = namedDistinctExpressions.map(_.toAttribute)
+ // Ideally this should be done in `NormalizeFloatingNumbers`, but we do it
here because
+ // `groupingExpressions` is not extracted during logical phase.
+ val normalizednamedDistinctExpressions = namedDistinctExpressions.map { e
=>
Review comment:
Thanks for taking the time @viirya. I am not 100% sure when all the
cases that need named expression, but that the physical node output expressions
need to be named, makes sense to me. Seems like any downstream node that needs
to refer to an output needs things like `ExprId` in order to distinguish fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
