Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5129#discussion_r26913783
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ---
    @@ -85,14 +85,19 @@ class CheckAnalysis {
     
                 cleaned.foreach(checkValidAggregateExpression)
     
    +          case _ => // Fallbacks to the following checks
    +        }
    +
    +        operator match {
               case o if o.children.nonEmpty &&
                 !o.references.filter(_.name != 
"grouping__id").subsetOf(o.inputSet) =>
    -            val missingAttributes = (o.references -- 
o.inputSet).map(_.prettyString).mkString(",")
    -            val input = o.inputSet.map(_.prettyString).mkString(",")
    +            val missingAttributes = (o.references -- 
o.inputSet).mkString(",")
    --- End diff --
    
    I'd like to take advantage over #5082, but I still have questions about 
that PR. So maybe I won't include related changes in this PR, but wait until 
#5082 is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to