HeartSaVioR commented on a change in pull request #28859:
URL: https://github.com/apache/spark/pull/28859#discussion_r443215446
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerDiskManager.scala
##########
@@ -83,6 +83,20 @@ private class HistoryServerDiskManager(
listing.delete(info.getClass(), info.path)
}
+ // Reading level db would trigger table file compaction, then it may cause
size of level db
Review comment:
We could apply "partition" instead of filter in L78, so that we only
call iterate with view once and retrieve two lists (orphans, existing) - L90
can use existing to avoid calling view again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
