kdzhao commented on a change in pull request #28731:
URL: https://github.com/apache/spark/pull/28731#discussion_r443269276
##########
File path: bin/beeline
##########
@@ -28,5 +28,7 @@ if [ -z "${SPARK_HOME}" ]; then
source "$(dirname "$0")"/find-spark-home
fi
+. "${SPARK_HOME}"/bin/load-spark-env.sh
+
CLASS="org.apache.hive.beeline.BeeLine"
-exec "${SPARK_HOME}/bin/spark-class" $CLASS "$@"
+exec "${SPARK_HOME}/bin/spark-class" $SPARK_SUBMIT_OPTS $CLASS "$@"
Review comment:
I took a look of how hive's beeline works, it looks like the suggested
fix for spark's beeline aligns well with that.
Also, spark's beeline actually calls "spark-class" (and some other code call
it as well), after tracing them one by one, the suggested fix seems to be the
safest way as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
