Ngone51 commented on pull request #28869: URL: https://github.com/apache/spark/pull/28869#issuecomment-647238903
> Thanks. The fix looks good. Do you think we can have a UT failing on master/branch-3.0 without this patch, @Ngone51 ? Before this patch, for an Aggregate operator, its input attributes will always be equal to or more than(because it refers to its own attributes while it should refer to the attributes from the child) its reference attributes. Therefore, its missing inputs must always be empty. Thus, I think we couldn't have a UT to cover it. After we correct the right references in this PR, the problem is then exposed in the UT of SPARK-31620, since missing inputs are no longer always empty. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
