dbtsai commented on a change in pull request #27366: URL: https://github.com/apache/spark/pull/27366#discussion_r443316503
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JsonFiltersSuite.scala ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.json + +import org.apache.spark.sql.catalyst.{StructFilters, StructFiltersSuite} +import org.apache.spark.sql.sources +import org.apache.spark.sql.types.StructType + +class JsonFiltersSuite extends StructFiltersSuite { + def createFilters(filters: Seq[sources.Filter], schema: StructType): StructFilters = { + new JsonFilters(filters, schema) + } Review comment: Do you think it's possible to implement nested situations? Although JSON is not columnar format, but if we are able to push down nested predicate, we will be able to avoid de-serialize unnecessary data. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
