wypoon commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-647762840
> Since this PR's contribution has an effect only when `spark.shuffle.service.enabled=true`, shall we narrow down the PR title? The current one seems to be too broad, `Unregister outputs for executor on fetch failure after executor is lost`. Technically, we have a test case `test(s"shuffle files $maybeLost when $eventDescription")` and we don't have a bug when `spark.shuffle.service.enabled=false`. Do we have a bug for both cases? The bug occurs when the shuffle service is enabled. I can change the PR title to reflect that, but it will make the title rather long. Oftentimes, a PR/commit title cannot fully explain the bug the PR is a fix for, and can only give a partial idea of the bug. I try to give a title that is not too long and still give *some* idea of the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
