Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/4491#issuecomment-84934768
@kellyzly
> i don't understand why need make CryptoOutputStream.scala#close safe. Is
there situation when
> multiple threads call this function at the same time?
It's general best practice, as you can't be confident of future uses. The
current impl is re-entrant, and as it doesn't set `closed=true` in the finally
clause, isn't actually guaranteed to set it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
