MaxGekk commented on a change in pull request #28886:
URL: https://github.com/apache/spark/pull/28886#discussion_r444081799
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -751,7 +751,8 @@ object IntervalUtils {
secs: Decimal): CalendarInterval = {
val totalMonths = Math.addExact(months, Math.multiplyExact(years,
MONTHS_PER_YEAR))
val totalDays = Math.addExact(days, Math.multiplyExact(weeks,
DAYS_PER_WEEK))
- var micros = (secs * Decimal(MICROS_PER_SECOND)).toLong
+ assert(secs.scale == 6, "Seconds fractional must have 6 digits for
microseconds")
Review comment:
I added assert there to guarantee that Int will not overflow. What would
you like to assert here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
