MaxGekk commented on a change in pull request #28905:
URL: https://github.com/apache/spark/pull/28905#discussion_r444153454
##########
File path: sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
##########
@@ -1,29 +1,39 @@
-Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
-Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux
4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
cast strings to intervals: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-prepare string w/ interval 448 469
20 2.2 447.6 1.0X
-prepare string w/o interval 405 409
4 2.5 404.6 1.1X
-1 units w/ interval 321 328
6 3.1 321.4 1.4X
-1 units w/o interval 303 307
4 3.3 303.1 1.5X
-2 units w/ interval 445 458
12 2.2 444.6 1.0X
-2 units w/o interval 416 424
10 2.4 416.2 1.1X
-3 units w/ interval 1006 1012
8 1.0 1006.4 0.4X
-3 units w/o interval 1240 1249
8 0.8 1239.6 0.4X
-4 units w/ interval 1295 1418
106 0.8 1295.4 0.3X
-4 units w/o interval 1172 1188
15 0.9 1171.6 0.4X
-5 units w/ interval 1326 1335
11 0.8 1325.6 0.3X
-5 units w/o interval 1309 1336
44 0.8 1308.7 0.3X
-6 units w/ interval 1441 1464
29 0.7 1441.0 0.3X
-6 units w/o interval 1350 1369
17 0.7 1350.1 0.3X
-7 units w/ interval 1606 1669
99 0.6 1605.6 0.3X
-7 units w/o interval 1546 1557
12 0.6 1546.3 0.3X
-8 units w/ interval 1771 1875
120 0.6 1770.6 0.3X
-8 units w/o interval 1775 1789
13 0.6 1775.2 0.3X
-9 units w/ interval 2126 2757
849 0.5 2126.4 0.2X
-9 units w/o interval 2053 2070
21 0.5 2053.3 0.2X
-10 units w/ interval 2209 2243
30 0.5 2209.1 0.2X
-10 units w/o interval 2400 2702
365 0.4 2400.2 0.2X
-11 units w/ interval 2616 2699
72 0.4 2616.5 0.2X
-11 units w/o interval 3218 3380
195 0.3 3218.4 0.1X
+prepare string w/ interval 744 823
81 1.3 744.3 1.0X
+prepare string w/o interval 612 620
12 1.6 611.9 1.2X
+1 units w/ interval 518 525
8 1.9 517.5 1.4X
+1 units w/o interval 475 477
2 2.1 475.0 1.6X
+2 units w/ interval 681 727
76 1.5 680.9 1.1X
+2 units w/o interval 654 660
10 1.5 653.5 1.1X
+3 units w/ interval 1319 1325
10 0.8 1318.6 0.6X
+3 units w/o interval 1330 1332
3 0.8 1329.7 0.6X
+4 units w/ interval 1723 1725
4 0.6 1722.8 0.4X
+4 units w/o interval 1723 1725
2 0.6 1723.1 0.4X
+5 units w/ interval 1906 1921
15 0.5 1906.4 0.4X
+5 units w/o interval 1902 1918
20 0.5 1901.9 0.4X
+6 units w/ interval 2109 2118
8 0.5 2108.8 0.4X
+6 units w/o interval 2102 2105
4 0.5 2102.3 0.4X
+7 units w/ interval 2324 2325
1 0.4 2324.5 0.3X
+7 units w/o interval 2381 2384
3 0.4 2380.9 0.3X
+8 units w/ interval 2460 2483
21 0.4 2459.6 0.3X
+8 units w/o interval 2452 2459
10 0.4 2452.3 0.3X
+9 units w/ interval 2714 2720
9 0.4 2714.3 0.3X
+9 units w/o interval 2707 2719
10 0.4 2707.4 0.3X
+10 units w/ interval 2860 2863
3 0.3 2859.8 0.3X
+10 units w/o interval 2853 2863
11 0.4 2852.9 0.3X
+11 units w/ interval 3156 3160
7 0.3 3155.5 0.2X
+11 units w/o interval 3169 3179
10 0.3 3168.8 0.2X
+
+OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04 on Linux
4.15.0-1063-aws
+Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+make_interval(): Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+prepare make_interval() 3396 3410
13 0.3 3395.6 1.0X
+make_interval(0,1,2,3,4,5,50.123456) 132 141
8 7.6 132.3 25.7X
Review comment:
This PR https://github.com/apache/spark/pull/28906 fixes the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
