HyukjinKwon commented on a change in pull request #28907:
URL: https://github.com/apache/spark/pull/28907#discussion_r444160979
##########
File path: R/pkg/tests/fulltests/test_mllib_classification.R
##########
@@ -130,7 +130,7 @@ test_that("spark.logit", {
summary <- summary(model)
# test summary coefficients return matrix type
- expect_true(class(summary$coefficients) == "matrix")
+ expect_true(any(class(summary$coefficients) == "matrix"))
Review comment:
> matrix objects now also inherit from class "array", so e.g.,
class(diag(1)) is c("matrix", "array"). This invalidates code incorrectly
assuming that class(matrix_obj)) has length one.
https://cran.r-project.org/doc/manuals/r-devel/NEWS.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
