Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5136#discussion_r26943512
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -91,7 +90,12 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
/** List all the files currently stored on disk by the disk manager. */
def getAllFiles(): Seq[File] = {
// Get all the files inside the array of array of directories
- subDirs.flatten.filter(_ != null).flatMap { dir =>
+ subDirs.flatMap { dir =>
--- End diff --
The earlier change makes sense, given what the intent of the code seems to
be. Is this one needed? cloning the array doesn't change any guarantees about
whether a call to this `get` method sees a particular update above or not. The
cloning of the array, like the read, will happen before or after any given
update. Or am I missing some correctness corner-case here that means something
throws an exception or something? just hoping to avoid complicating this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
