cloud-fan commented on a change in pull request #28919:
URL: https://github.com/apache/spark/pull/28919#discussion_r445051121
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -460,7 +460,12 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// because `distinctExpressions` is not extracted during logical
phase.
NormalizeFloatingNumbers.normalize(e) match {
case ne: NamedExpression => ne
- case other => Alias(other, other.toString)()
+ case other =>
+ val name = e match {
+ case ne: NamedExpression => ne.name
+ case other => other.toString
Review comment:
Yes, that `other` is
`KnownFloatingPointNormalized(NormalizeNaNAndZero(expr))`, which has a very
long string representation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
