Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5124#discussion_r26961357
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -805,7 +806,7 @@ class DAGScheduler(
         }
     
         val properties = if (jobIdToActiveJob.contains(jobId)) {
    -      jobIdToActiveJob(stage.jobId).properties
    +      jobIdToActiveJob(stage.jobId).properties.orNull
    --- End diff --
    
    I don't know if there's a good reason for this, but I don't think we can 
change it at this point without breaking binary compatibility.  We could use 
annotations / comments to make those fields' nullability more apparent, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to