Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r26966346
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -540,6 +560,27 @@ private[spark] class Client(
         amContainer
       }
     
    +  def setupCredentials(): Unit = {
    +    if (args.principal != null) {
    +      Preconditions.checkNotNull(
    --- End diff --
    
    sorry for flip-flopping here. The methods in `Preconditions` work weirdly 
in Scala as you've noticed. Should probably use Scala's `require()` here (which 
throws IllegalArgumentException, which is also a little more correct).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to