wypoon commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-649968228
In the latest update, there are three changes: 1. `failedEpoch` and `fileLostEpoch` are renamed and comments explaining what they are are expanded, largely based on suggestions from @squito. 2. A call to `clearCacheLocs` is moved into the correct if block in `removeExecutorAndUnregisterOutputs`. 3. In `DAGSchedulerSuite`, `mapOutputTracker` and `blockManagerMaster` are wrapped by `Mockito.spy` and the spies are used to verify how many times each is called. This verification is added to some existing tests, which pass without my change to `DAGScheduler`. The verification is also added to the new test case for this bug. Thanks to @attilapiros for his illustrative example using `Mockito.spy`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
