HyukjinKwon commented on a change in pull request #28685:
URL: https://github.com/apache/spark/pull/28685#discussion_r446082124
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -363,6 +363,11 @@ abstract class OffsetWindowFunction
*/
val direction: SortDirection
+ /**
+ * Whether the offset is based on the entire frame.
+ */
+ val isWholeBased: Boolean = false
Review comment:
Hm, quick question, why didn't you just pattern match at
`WindowExecBase.scala ` instead of having this flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
