tgravescs commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r445553889
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1235,7 +1236,7 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
private def deleteLog(fs: FileSystem, log: Path): Boolean = {
var deleted = false
- if (isBlacklisted(log)) {
+ if (!isAccessible(log)) {
Review comment:
I think this should function should be isInAccessible or you have to
change its logic. You added the ! but the isAccessible function does the same
thing the isBlacklisted did. Probably why tests are failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
