maropu commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r446509317
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
##########
@@ -488,6 +489,25 @@ class FileIndexSuite extends SharedSparkSession {
val fileIndex = new TestInMemoryFileIndex(spark, path)
assert(fileIndex.leafFileStatuses.toSeq == statuses)
}
+
+ test("expire FileStatusCache if TTL is configured") {
+ withSQLConf(SQLConf.METADATA_CACHE_TTL.key -> "1") {
+ val path = new Path("/tmp", "abc")
+ val files = (1 to 3).map(_ => new FileStatus())
+
+ FileStatusCache.resetForTesting()
+ val fileStatusCache = FileStatusCache.getOrCreate(spark)
+ fileStatusCache.putLeafFiles(path, files.toArray)
+
+ // Exactly 3 files are cached.
+ assert(fileStatusCache.getLeafFiles(path).get.length === 3)
+ // Wait until the cache expiration.
+ eventually(timeout(2.seconds)) {
Review comment:
Could you make this time a bit longer to avoid test flakiness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
