dbaliafroozeh commented on a change in pull request #28885:
URL: https://github.com/apache/spark/pull/28885#discussion_r446514163
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -326,7 +327,8 @@ object QueryExecution {
*/
private[execution] def preparations(
sparkSession: SparkSession,
- adaptiveExecutionRule: Option[InsertAdaptiveSparkPlan] = None):
Seq[Rule[SparkPlan]] = {
+ adaptiveExecutionRule: Option[InsertAdaptiveSparkPlan] = None,
+ subquery: Boolean): Seq[Rule[SparkPlan]] = {
Review comment:
Why do we need this boolean parameter here? What will happen if we just
always run the `WholePlanReuse` rule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
