dongjoon-hyun commented on a change in pull request #28935: URL: https://github.com/apache/spark/pull/28935#discussion_r446595757
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/HiveNullType.scala ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.types + +/** + * A hive null type for compatibility. These datatypes should only used for parsing, + * and should NOT be used anywhere else. Any instance of these data types should be + * replaced by a [[NullType]] before analysis. + */ +class HiveNullType private() extends DataType { + + override def defaultSize: Int = 1 + + override private[spark] def asNullable: HiveNullType = this + + override def simpleString: String = "void" +} + +case object HiveNullType extends HiveNullType { + def replaceNullType(dt: DataType): DataType = dt match { + case ArrayType(et, nullable) => + ArrayType(replaceNullType(et), nullable) + case MapType(kt, vt, nullable) => + MapType(replaceNullType(kt), replaceNullType(vt), nullable) + case StructType(fields) => + StructType(fields.map { field => + field.copy(dataType = replaceNullType(field.dataType)) + }) Review comment: Maybe, the following is shorter as a one-liner. ```scala StructType(fields.map(f => f.copy(dataType = replaceNullType(f.dataType)))) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
