moomindani commented on a change in pull request #27690:
URL: https://github.com/apache/spark/pull/27690#discussion_r446516892
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
##########
@@ -97,12 +99,38 @@ private[hive] trait SaveAsHiveFile extends
DataWritingCommand {
options = Map.empty)
}
- protected def getExternalTmpPath(
+ // Mostly copied from Context.java#getMRTmpPath of Hive 2.3.
+ // Visible for testing.
+ private[execution] def getNonBlobTmpPath(
+ hadoopConf: Configuration,
+ sessionScratchDir: String,
+ scratchDir: String): Path = {
+
+ // Hive's getMRTmpPath uses nonLocalScratchPath + '-mr-10000',
+ // which is ruled by 'hive.exec.scratchdir' including file system.
+ // This is the same as Spark's #oldVersionExternalTempPath.
+ // Only difference between #oldVersionExternalTempPath and Hive 2.3.0's is
HIVE-7090.
+ // HIVE-7090 added user_name/session_id on top of 'hive.exec.scratchdir'
+ // Here it uses session_path unless it's emtpy, otherwise uses scratchDir.
+ val sessionPath = if (!sessionScratchDir.isEmpty) sessionScratchDir else
scratchDir
+ val mrScratchDir = oldVersionExternalTempPath(new Path(sessionPath),
hadoopConf, sessionPath)
Review comment:
Hive has two kinds of scratch dir accordingly, one in local, the other
in hdfs.
https://mingyue.me/2018/11/17/hive-scratch-working-directory/
In this pull-request, the latter one, `hive.exec.scratchdir` is used. In my
recognition, we can assume HDFS schema in most cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
