peter-toth commented on a change in pull request #28885:
URL: https://github.com/apache/spark/pull/28885#discussion_r446632217
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -326,7 +327,8 @@ object QueryExecution {
*/
private[execution] def preparations(
sparkSession: SparkSession,
- adaptiveExecutionRule: Option[InsertAdaptiveSparkPlan] = None):
Seq[Rule[SparkPlan]] = {
+ adaptiveExecutionRule: Option[InsertAdaptiveSparkPlan] = None,
+ subquery: Boolean): Seq[Rule[SparkPlan]] = {
Review comment:
Sorry, I don't get this, why would we run this rule multiple times? This
new rule traverses through the whole plan, does it make any sense to run in on
subqueries and then run it on a main query which also incorporates traversing
on subqueries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
