karuppayya commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-650843729
> > No, The Final aggregation will take care giving the right results. > > This is like more like setting the Aggregation mode to org.apache.spark.sql.catalyst.expressions.aggregate.Complete > > Ah, I see. We cannot just rewrite a plan from the two-phase aggregate (w/ partial mode) to a single-phase one (w/ complete mode) for the case during optimizing plans? That should be possible. I wanted to get rid of the config based approach and come up with a mechanism to identify such cases at runtime for which codegen changes is required. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
