maropu commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-650844833
The current approach looks a bit hacky because you implemented the optimization directly in generated aggregate code. You might be able to use `Aggregation` in `SparkStrategies` for the optimization. Could you try? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
